jsauer/torvalds-linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-01-11 17:10:13 +00:00
Code

Revert "usb: typec: ucsi: Enable debugfs for message_out data structure"

Browse Source 
This reverts commit 775fae520e6ae62c393a8daf42dc534f09692f3f.

The new buffer management code that this relies on is broken so revert
for now.

It also looks like the error handling needs some more thought as the
message out size is not reset on errors.

Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://patch.msgid.link/20251222152204.2846-3-johan@kernel.org
This commit is contained in:
Johan Hovold 2025-12-22 16:22:02 +01:00 committed by Greg Kroah-Hartman
parent 784b756dde
commit 174e7d0f47
1 changed files with 0 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
drivers/usb/typec/ucsi/debugfs.c
View File

@ -110,30 +110,6 @@ static int ucsi_vbus_volt_show(struct seq_file *m, void *v)
}
DEFINE_SHOW_ATTRIBUTE(ucsi_vbus_volt);
static ssize_t ucsi_message_out_write(struct file *file,
const char __user *data, size_t count, loff_t *ppos)
{
struct ucsi *ucsi = file->private_data;
int ret;
char *buf __free(kfree) = memdup_user_nul(data, count);
if (IS_ERR(buf))
return PTR_ERR(buf);
ucsi->message_out_size = min(count / 2, UCSI_MAX_MESSAGE_OUT_LENGTH);
ret = hex2bin(ucsi->message_out, buf, ucsi->message_out_size);
if (ret)
return ret;
return count;
}
static const struct file_operations ucsi_message_out_fops = {
.open = simple_open,
.write = ucsi_message_out_write,
.llseek = generic_file_llseek,
};
void ucsi_debugfs_register(struct ucsi *ucsi)
{
ucsi->debugfs = kzalloc(sizeof(*ucsi->debugfs), GFP_KERNEL);
@ -146,8 +122,6 @@ void ucsi_debugfs_register(struct ucsi *ucsi)
debugfs_create_file("peak_current", 0400, ucsi->debugfs->dentry, ucsi, &ucsi_peak_curr_fops);
debugfs_create_file("avg_current", 0400, ucsi->debugfs->dentry, ucsi, &ucsi_avg_curr_fops);
debugfs_create_file("vbus_voltage", 0400, ucsi->debugfs->dentry, ucsi, &ucsi_vbus_volt_fops);
debugfs_create_file("message_out", 0200, ucsi->debugfs->dentry, ucsi,
&ucsi_message_out_fops);
}
void ucsi_debugfs_unregister(struct ucsi *ucsi)