jsauer/torvalds-linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-01-12 09:32:12 +00:00
Code

selftets/damon: add a test for memcg_path leak

Browse Source 
There was a memory leak bug in DAMOS sysfs memcg_path file.  Add a
selftest to ensure the bug never comes back.

Link: https://lkml.kernel.org/r/20250619183608.6647-3-sj@kernel.org
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Shuah Khan <shuah@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
SeongJae Park 2025-06-19 11:36:08 -07:00 committed by Andrew Morton
parent 5d26b5bdc6
commit dfa3cf0bc0
2 changed files with 44 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tools/testing/selftests/damon/Makefile
View File

@ -15,6 +15,7 @@ TEST_PROGS += reclaim.sh lru_sort.sh
# regression tests (reproducers of previously found bugs)
TEST_PROGS += sysfs_update_removed_scheme_dir.sh
TEST_PROGS += sysfs_update_schemes_tried_regions_hang.py
TEST_PROGS += sysfs_memcg_path_leak.sh
EXTRA_CLEAN = __pycache__

43
tools/testing/selftests/damon/sysfs_memcg_path_leak.sh Executable file
View File

@ -0,0 +1,43 @@
#!/bin/bash
# SPDX-License-Identifier: GPL-2.0
if [ $EUID -ne 0 ]
then
echo "Run as root"
exit $ksft_skip
fi
damon_sysfs="/sys/kernel/mm/damon/admin"
if [ ! -d "$damon_sysfs" ]
then
echo "damon sysfs not found"
exit $ksft_skip
fi
# ensure filter directory
echo 1 > "$damon_sysfs/kdamonds/nr_kdamonds"
echo 1 > "$damon_sysfs/kdamonds/0/contexts/nr_contexts"
echo 1 > "$damon_sysfs/kdamonds/0/contexts/0/schemes/nr_schemes"
echo 1 > "$damon_sysfs/kdamonds/0/contexts/0/schemes/0/filters/nr_filters"
filter_dir="$damon_sysfs/kdamonds/0/contexts/0/schemes/0/filters/0"
before_kb=$(grep Slab /proc/meminfo | awk '{print $2}')
# try to leak 3000 KiB
for i in {1..102400};
do
echo "012345678901234567890123456789" > "$filter_dir/memcg_path"
done
after_kb=$(grep Slab /proc/meminfo | awk '{print $2}')
# expect up to 1500 KiB free from other tasks memory
expected_after_kb_max=$((before_kb + 1500))
if [ "$after_kb" -gt "$expected_after_kb_max" ]
then
echo "maybe memcg_path are leaking: $before_kb -> $after_kb"
exit 1
else
exit 0
fi