jsauer/torvalds-linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-01-11 17:10:13 +00:00
Code

dm-mpath: make dm_unregister_path_selector return void

Browse Source 
dm_unregister_path_selector may only return error if there's a bug in the
code - so we make it return void and print a warning if the user abuses
this function to unregister a target that was not registered.

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
This commit is contained in:
Mikulas Patocka 2025-06-30 15:23:03 +02:00
parent ebbd17695e
commit f86272350f
7 changed files with 9 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/md/dm-path-selector.c
View File

@ -117,16 +117,16 @@ int dm_register_path_selector(struct path_selector_type *pst)
} }
EXPORT_SYMBOL_GPL(dm_register_path_selector); EXPORT_SYMBOL_GPL(dm_register_path_selector);
int dm_unregister_path_selector(struct path_selector_type *pst) void dm_unregister_path_selector(struct path_selector_type *pst)
{ {
struct ps_internal *psi; struct ps_internal *psi;
down_write(&_ps_lock); down_write(&_ps_lock);
psi = __find_path_selector_type(pst->name); psi = __find_path_selector_type(pst->name);
if (!psi) { if (WARN_ON(!psi)) {
up_write(&_ps_lock); up_write(&_ps_lock);
return -EINVAL; return;
} }
list_del(&psi->list); list_del(&psi->list);
@ -134,7 +134,5 @@ int dm_unregister_path_selector(struct path_selector_type *pst)
up_write(&_ps_lock); up_write(&_ps_lock);
kfree(psi); kfree(psi);
return 0;
} }
EXPORT_SYMBOL_GPL(dm_unregister_path_selector); EXPORT_SYMBOL_GPL(dm_unregister_path_selector);

2
drivers/md/dm-path-selector.h
View File

@ -96,7 +96,7 @@ struct path_selector_type {
int dm_register_path_selector(struct path_selector_type *type); int dm_register_path_selector(struct path_selector_type *type);
/* Unregister a path selector */ /* Unregister a path selector */
int dm_unregister_path_selector(struct path_selector_type *type); void dm_unregister_path_selector(struct path_selector_type *type);
/* Returns a registered path selector type */ /* Returns a registered path selector type */
struct path_selector_type *dm_get_path_selector(const char *name); struct path_selector_type *dm_get_path_selector(const char *name);

5
drivers/md/dm-ps-historical-service-time.c
View File

@ -551,10 +551,7 @@ static int __init dm_hst_init(void)
static void __exit dm_hst_exit(void) static void __exit dm_hst_exit(void)
{ {
int r = dm_unregister_path_selector(&hst_ps); dm_unregister_path_selector(&hst_ps);
if (r < 0)
DMERR("unregister failed %d", r);
} }
module_init(dm_hst_init); module_init(dm_hst_init);

5
drivers/md/dm-ps-io-affinity.c
View File

@ -260,10 +260,7 @@ static int __init dm_ioa_init(void)
static void __exit dm_ioa_exit(void) static void __exit dm_ioa_exit(void)
{ {
int ret = dm_unregister_path_selector(&ioa_ps); dm_unregister_path_selector(&ioa_ps);
if (ret < 0)
DMERR("unregister failed %d", ret);
} }
module_init(dm_ioa_init); module_init(dm_ioa_init);

5
drivers/md/dm-ps-queue-length.c
View File

@ -270,10 +270,7 @@ static int __init dm_ql_init(void)
static void __exit dm_ql_exit(void) static void __exit dm_ql_exit(void)
{ {
int r = dm_unregister_path_selector(&ql_ps); dm_unregister_path_selector(&ql_ps);
if (r < 0)
DMERR("unregister failed %d", r);
} }
module_init(dm_ql_init); module_init(dm_ql_init);

5
drivers/md/dm-ps-round-robin.c
View File

@ -230,10 +230,7 @@ static int __init dm_rr_init(void)
static void __exit dm_rr_exit(void) static void __exit dm_rr_exit(void)
{ {
int r = dm_unregister_path_selector(&rr_ps); dm_unregister_path_selector(&rr_ps);
if (r < 0)
DMERR("unregister failed %d", r);
} }
module_init(dm_rr_init); module_init(dm_rr_init);

5
drivers/md/dm-ps-service-time.c
View File

@ -351,10 +351,7 @@ static int __init dm_st_init(void)
static void __exit dm_st_exit(void) static void __exit dm_st_exit(void)
{ {
int r = dm_unregister_path_selector(&st_ps); dm_unregister_path_selector(&st_ps);
if (r < 0)
DMERR("unregister failed %d", r);
} }
module_init(dm_st_init); module_init(dm_st_init);