mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-01-16 19:45:39 +00:00
7ed51e3a13
ISP mfd child devices are using genpd and the system suspend-resume operations between genpd and amdgpu parent device which uses only runtime suspend-resume are not in sync. Linux power manager during suspend-resume resuming the genpd devices earlier than the amdgpu parent device. This is resulting in the below warning as SMU is in suspended state when genpd attempts to resume ISP. WARNING: CPU: 13 PID: 5435 at drivers/gpu/drm/amd/amdgpu/../pm/swsmu/amdgpu_smu.c:398 smu_dpm_set_power_gate+0x36f/0x380 [amdgpu] To fix this warning isp suspend-resume is handled as part of amdgpu parent device suspend-resume instead of genpd sequence. Each ISP MFD child device is marked as dev_pm_syscore_device to skip genpd suspend-resume and use pm_runtime_force api's to suspend-resume the devices when callbacks from amdgpu are received. Co-developed-by: Gjorgji Rosikopulos <grosikop@amd.com> Signed-off-by: Gjorgji Rosikopulos <grosikop@amd.com> Signed-off-by: Bin Du <bin.du@amd.com> Signed-off-by: Pratap Nirujogi <pratap.nirujogi@amd.com> Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> (cherry picked from commit 0288a345f19b2162546352161509bb24614729e1)
63 lines
2.1 KiB
C
63 lines
2.1 KiB
C
/* SPDX-License-Identifier: MIT */
|
|
/*
|
|
* Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.
|
|
* All Rights Reserved.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the
|
|
* "Software"), to deal in the Software without restriction, including
|
|
* without limitation the rights to use, copy, modify, merge, publish,
|
|
* distribute, sub license, and/or sell copies of the Software, and to
|
|
* permit persons to whom the Software is furnished to do so, subject to
|
|
* the following conditions:
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL
|
|
* THE COPYRIGHT HOLDERS, AUTHORS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM,
|
|
* DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
* OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
* USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
* The above copyright notice and this permission notice (including the
|
|
* next paragraph) shall be included in all copies or substantial portions
|
|
* of the Software.
|
|
*
|
|
*/
|
|
|
|
#ifndef __AMDGPU_ISP_H__
|
|
#define __AMDGPU_ISP_H__
|
|
|
|
#include <drm/amd/isp.h>
|
|
#include <linux/pm_domain.h>
|
|
|
|
#define ISP_REGS_OFFSET_END 0x629A4
|
|
|
|
struct amdgpu_isp;
|
|
|
|
struct isp_funcs {
|
|
int (*hw_init)(struct amdgpu_isp *isp);
|
|
int (*hw_fini)(struct amdgpu_isp *isp);
|
|
int (*hw_suspend)(struct amdgpu_isp *isp);
|
|
int (*hw_resume)(struct amdgpu_isp *isp);
|
|
};
|
|
|
|
struct amdgpu_isp {
|
|
struct device *parent;
|
|
struct amdgpu_device *adev;
|
|
const struct isp_funcs *funcs;
|
|
struct mfd_cell *isp_cell;
|
|
struct resource *isp_res;
|
|
struct resource *isp_i2c_res;
|
|
struct resource *isp_gpio_res;
|
|
struct isp_platform_data *isp_pdata;
|
|
unsigned int harvest_config;
|
|
const struct firmware *fw;
|
|
struct generic_pm_domain ispgpd;
|
|
};
|
|
|
|
extern const struct amdgpu_ip_block_version isp_v4_1_0_ip_block;
|
|
extern const struct amdgpu_ip_block_version isp_v4_1_1_ip_block;
|
|
|
|
#endif /* __AMDGPU_ISP_H__ */
|