mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-01-11 17:10:13 +00:00
The .free callback cleared among others the enable bit PWENx in the
control register. When the PWM is requested later again this bit isn't
restored but the core assumes the PWM is enabled and thus skips a
request to configure the same state as before.
To fix that don't touch the hardware configuration in .free(). For
symmetry also drop .request() and configure the mode completely in
.apply().
Fixes: e5a06dc5ac1f ("pwm: Add BCM2835 PWM driver")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://patch.msgid.link/20251118174303.1761577-2-u.kleine-koenig@baylibre.com
Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
186 lines
4.7 KiB
C
186 lines
4.7 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Copyright 2014 Bart Tanghe <bart.tanghe@thomasmore.be>
|
|
*/
|
|
|
|
#include <linux/clk.h>
|
|
#include <linux/err.h>
|
|
#include <linux/io.h>
|
|
#include <linux/module.h>
|
|
#include <linux/of.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/pwm.h>
|
|
|
|
#define PWM_CONTROL 0x000
|
|
#define PWM_CONTROL_SHIFT(x) ((x) * 8)
|
|
#define PWM_CONTROL_MASK 0xff
|
|
#define PWM_MODE 0x80 /* set timer in PWM mode */
|
|
#define PWM_ENABLE (1 << 0)
|
|
#define PWM_POLARITY (1 << 4)
|
|
|
|
#define PERIOD(x) (((x) * 0x10) + 0x10)
|
|
#define DUTY(x) (((x) * 0x10) + 0x14)
|
|
|
|
#define PERIOD_MIN 0x2
|
|
|
|
struct bcm2835_pwm {
|
|
void __iomem *base;
|
|
struct clk *clk;
|
|
unsigned long rate;
|
|
};
|
|
|
|
static inline struct bcm2835_pwm *to_bcm2835_pwm(struct pwm_chip *chip)
|
|
{
|
|
return pwmchip_get_drvdata(chip);
|
|
}
|
|
|
|
static int bcm2835_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
|
|
const struct pwm_state *state)
|
|
{
|
|
|
|
struct bcm2835_pwm *pc = to_bcm2835_pwm(chip);
|
|
unsigned long long period_cycles;
|
|
u64 max_period;
|
|
|
|
u32 val;
|
|
|
|
/*
|
|
* period_cycles must be a 32 bit value, so period * rate / NSEC_PER_SEC
|
|
* must be <= U32_MAX. As U32_MAX * NSEC_PER_SEC < U64_MAX the
|
|
* multiplication period * rate doesn't overflow.
|
|
* To calculate the maximal possible period that guarantees the
|
|
* above inequality:
|
|
*
|
|
* round(period * rate / NSEC_PER_SEC) <= U32_MAX
|
|
* <=> period * rate / NSEC_PER_SEC < U32_MAX + 0.5
|
|
* <=> period * rate < (U32_MAX + 0.5) * NSEC_PER_SEC
|
|
* <=> period < ((U32_MAX + 0.5) * NSEC_PER_SEC) / rate
|
|
* <=> period < ((U32_MAX * NSEC_PER_SEC + NSEC_PER_SEC/2) / rate
|
|
* <=> period <= ceil((U32_MAX * NSEC_PER_SEC + NSEC_PER_SEC/2) / rate) - 1
|
|
*/
|
|
max_period = DIV_ROUND_UP_ULL((u64)U32_MAX * NSEC_PER_SEC + NSEC_PER_SEC / 2, pc->rate) - 1;
|
|
|
|
if (state->period > max_period)
|
|
return -EINVAL;
|
|
|
|
/* set period */
|
|
period_cycles = DIV_ROUND_CLOSEST_ULL(state->period * pc->rate, NSEC_PER_SEC);
|
|
|
|
/* don't accept a period that is too small */
|
|
if (period_cycles < PERIOD_MIN)
|
|
return -EINVAL;
|
|
|
|
writel(period_cycles, pc->base + PERIOD(pwm->hwpwm));
|
|
|
|
/* set duty cycle */
|
|
val = DIV_ROUND_CLOSEST_ULL(state->duty_cycle * pc->rate, NSEC_PER_SEC);
|
|
writel(val, pc->base + DUTY(pwm->hwpwm));
|
|
|
|
/* set polarity */
|
|
val = readl(pc->base + PWM_CONTROL);
|
|
|
|
val &= ~(PWM_CONTROL_MASK << PWM_CONTROL_SHIFT(pwm->hwpwm));
|
|
val |= PWM_MODE << PWM_CONTROL_SHIFT(pwm->hwpwm);
|
|
|
|
if (state->polarity == PWM_POLARITY_NORMAL)
|
|
val &= ~(PWM_POLARITY << PWM_CONTROL_SHIFT(pwm->hwpwm));
|
|
else
|
|
val |= PWM_POLARITY << PWM_CONTROL_SHIFT(pwm->hwpwm);
|
|
|
|
/* enable/disable */
|
|
if (state->enabled)
|
|
val |= PWM_ENABLE << PWM_CONTROL_SHIFT(pwm->hwpwm);
|
|
else
|
|
val &= ~(PWM_ENABLE << PWM_CONTROL_SHIFT(pwm->hwpwm));
|
|
|
|
writel(val, pc->base + PWM_CONTROL);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct pwm_ops bcm2835_pwm_ops = {
|
|
.apply = bcm2835_pwm_apply,
|
|
};
|
|
|
|
static int bcm2835_pwm_probe(struct platform_device *pdev)
|
|
{
|
|
struct device *dev = &pdev->dev;
|
|
struct pwm_chip *chip;
|
|
struct bcm2835_pwm *pc;
|
|
int ret;
|
|
|
|
chip = devm_pwmchip_alloc(dev, 2, sizeof(*pc));
|
|
if (IS_ERR(chip))
|
|
return PTR_ERR(chip);
|
|
pc = to_bcm2835_pwm(chip);
|
|
|
|
pc->base = devm_platform_ioremap_resource(pdev, 0);
|
|
if (IS_ERR(pc->base))
|
|
return PTR_ERR(pc->base);
|
|
|
|
pc->clk = devm_clk_get_enabled(dev, NULL);
|
|
if (IS_ERR(pc->clk))
|
|
return dev_err_probe(dev, PTR_ERR(pc->clk),
|
|
"clock not found\n");
|
|
|
|
ret = devm_clk_rate_exclusive_get(dev, pc->clk);
|
|
if (ret)
|
|
return dev_err_probe(dev, ret,
|
|
"fail to get exclusive rate\n");
|
|
|
|
pc->rate = clk_get_rate(pc->clk);
|
|
if (!pc->rate)
|
|
return dev_err_probe(dev, -EINVAL,
|
|
"failed to get clock rate\n");
|
|
|
|
chip->ops = &bcm2835_pwm_ops;
|
|
chip->atomic = true;
|
|
|
|
platform_set_drvdata(pdev, pc);
|
|
|
|
ret = devm_pwmchip_add(dev, chip);
|
|
if (ret < 0)
|
|
return dev_err_probe(dev, ret, "failed to add pwmchip\n");
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int bcm2835_pwm_suspend(struct device *dev)
|
|
{
|
|
struct bcm2835_pwm *pc = dev_get_drvdata(dev);
|
|
|
|
clk_disable_unprepare(pc->clk);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int bcm2835_pwm_resume(struct device *dev)
|
|
{
|
|
struct bcm2835_pwm *pc = dev_get_drvdata(dev);
|
|
|
|
return clk_prepare_enable(pc->clk);
|
|
}
|
|
|
|
static DEFINE_SIMPLE_DEV_PM_OPS(bcm2835_pwm_pm_ops, bcm2835_pwm_suspend,
|
|
bcm2835_pwm_resume);
|
|
|
|
static const struct of_device_id bcm2835_pwm_of_match[] = {
|
|
{ .compatible = "brcm,bcm2835-pwm", },
|
|
{ /* sentinel */ }
|
|
};
|
|
MODULE_DEVICE_TABLE(of, bcm2835_pwm_of_match);
|
|
|
|
static struct platform_driver bcm2835_pwm_driver = {
|
|
.driver = {
|
|
.name = "bcm2835-pwm",
|
|
.of_match_table = bcm2835_pwm_of_match,
|
|
.pm = pm_ptr(&bcm2835_pwm_pm_ops),
|
|
},
|
|
.probe = bcm2835_pwm_probe,
|
|
};
|
|
module_platform_driver(bcm2835_pwm_driver);
|
|
|
|
MODULE_AUTHOR("Bart Tanghe <bart.tanghe@thomasmore.be>");
|
|
MODULE_DESCRIPTION("Broadcom BCM2835 PWM driver");
|
|
MODULE_LICENSE("GPL v2");
|