mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-01-16 19:45:39 +00:00
After commit 84caf98838a3e5f4bdb34 ("mm: stop storing migration_ops in
page->mapping") we get such an error message if CONFIG_ZSMALLOC=m:
WARNING: CPU: 3 PID: 42 at mm/migrate.c:142 isolate_movable_ops_page+0xa8/0x1c0
CPU: 3 UID: 0 PID: 42 Comm: kcompactd0 Not tainted 6.16.0-rc5+ #2133 PREEMPT
pc 9000000000540bd8 ra 9000000000540b84 tp 9000000100420000 sp 9000000100423a60
a0 9000000100193a80 a1 000000000000000c a2 000000000000001b a3 ffffffffffffffff
a4 ffffffffffffffff a5 0000000000000267 a6 0000000000000000 a7 9000000100423ae0
t0 00000000000000f1 t1 00000000000000f6 t2 0000000000000000 t3 0000000000000001
t4 ffffff00010eb834 t5 0000000000000040 t6 900000010c89d380 t7 90000000023fcc70
t8 0000000000000018 u0 0000000000000000 s9 ffffff00010eb800 s0 ffffff00010eb800
s1 000000000000000c s2 0000000000043ae0 s3 0000800000000000 s4 900000000219cc40
s5 0000000000000000 s6 ffffff00010eb800 s7 0000000000000001 s8 90000000025b4000
ra: 9000000000540b84 isolate_movable_ops_page+0x54/0x1c0
ERA: 9000000000540bd8 isolate_movable_ops_page+0xa8/0x1c0
CRMD: 000000b0 (PLV0 -IE -DA +PG DACF=CC DACM=CC -WE)
PRMD: 00000004 (PPLV0 +PIE -PWE)
EUEN: 00000000 (-FPE -SXE -ASXE -BTE)
ECFG: 00071c1d (LIE=0,2-4,10-12 VS=7)
ESTAT: 000c0000 [BRK] (IS= ECode=12 EsubCode=0)
PRID: 0014c010 (Loongson-64bit, Loongson-3A5000)
CPU: 3 UID: 0 PID: 42 Comm: kcompactd0 Not tainted 6.16.0-rc5+ #2133 PREEMPT
Stack : 90000000021fd000 0000000000000000 9000000000247720 9000000100420000
90000001004236a0 90000001004236a8 0000000000000000 90000001004237e8
90000001004237e0 90000001004237e0 9000000100423550 0000000000000001
0000000000000001 90000001004236a8 725a84864a19e2d9 90000000023fcc58
9000000100420000 90000000024c6848 9000000002416848 0000000000000001
0000000000000000 000000000000000a 0000000007fe0000 ffffff00010eb800
0000000000000000 90000000021fd000 0000000000000000 900000000205cf30
000000000000008e 0000000000000009 ffffff00010eb800 0000000000000001
90000000025b4000 0000000000000000 900000000024773c 00007ffff103d748
00000000000000b0 0000000000000004 0000000000000000 0000000000071c1d
...
Call Trace:
[<900000000024773c>] show_stack+0x5c/0x190
[<90000000002415e0>] dump_stack_lvl+0x70/0x9c
[<90000000004abe6c>] isolate_migratepages_block+0x3bc/0x16e0
[<90000000004af408>] compact_zone+0x558/0x1000
[<90000000004b0068>] compact_node+0xa8/0x1e0
[<90000000004b0aa4>] kcompactd+0x394/0x410
[<90000000002b3c98>] kthread+0x128/0x140
[<9000000001779148>] ret_from_kernel_thread+0x28/0xc0
[<9000000000245528>] ret_from_kernel_thread_asm+0x10/0x88
The reason is that defined(CONFIG_ZSMALLOC) evaluates to 1 only when
CONFIG_ZSMALLOC=y, we should use IS_ENABLED(CONFIG_ZSMALLOC) instead. But
when I use IS_ENABLED(CONFIG_ZSMALLOC), page_movable_ops() cannot access
zsmalloc_mops because zsmalloc_mops is in a module.
To solve this problem, we define a set_movable_ops() interface to register
and unregister offline_movable_ops / zsmalloc_movable_ops in mm/migrate.c,
and call them at mm/balloon_compaction.c & mm/zsmalloc.c. Since
offline_movable_ops / zsmalloc_movable_ops are always accessible, all
#ifdef / #endif are removed in page_movable_ops().
Link: https://lkml.kernel.org/r/20250817151759.2525174-1-chenhuacai@loongson.cn
Fixes: 84caf98838a3 ("mm: stop storing migration_ops in page->mapping")
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
Acked-by: Zi Yan <ziy@nvidia.com>
Acked-by: David Hildenbrand <david@redhat.com>
Cc: Huacai Chen <chenhuacai@kernel.org>
Cc: Huacai Chen <chenhuacai@loongson.cn>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
206 lines
7.0 KiB
C
206 lines
7.0 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef _LINUX_MIGRATE_H
|
|
#define _LINUX_MIGRATE_H
|
|
|
|
#include <linux/mm.h>
|
|
#include <linux/mempolicy.h>
|
|
#include <linux/migrate_mode.h>
|
|
#include <linux/hugetlb.h>
|
|
|
|
typedef struct folio *new_folio_t(struct folio *folio, unsigned long private);
|
|
typedef void free_folio_t(struct folio *folio, unsigned long private);
|
|
|
|
struct migration_target_control;
|
|
|
|
/*
|
|
* Return values from addresss_space_operations.migratepage():
|
|
* - negative errno on page migration failure;
|
|
* - zero on page migration success;
|
|
*/
|
|
#define MIGRATEPAGE_SUCCESS 0
|
|
#define MIGRATEPAGE_UNMAP 1
|
|
|
|
/**
|
|
* struct movable_operations - Driver page migration
|
|
* @isolate_page:
|
|
* The VM calls this function to prepare the page to be moved. The page
|
|
* is locked and the driver should not unlock it. The driver should
|
|
* return ``true`` if the page is movable and ``false`` if it is not
|
|
* currently movable. After this function returns, the VM uses the
|
|
* page->lru field, so the driver must preserve any information which
|
|
* is usually stored here.
|
|
*
|
|
* @migrate_page:
|
|
* After isolation, the VM calls this function with the isolated
|
|
* @src page. The driver should copy the contents of the
|
|
* @src page to the @dst page and set up the fields of @dst page.
|
|
* Both pages are locked.
|
|
* If page migration is successful, the driver should
|
|
* return MIGRATEPAGE_SUCCESS.
|
|
* If the driver cannot migrate the page at the moment, it can return
|
|
* -EAGAIN. The VM interprets this as a temporary migration failure and
|
|
* will retry it later. Any other error value is a permanent migration
|
|
* failure and migration will not be retried.
|
|
* The driver shouldn't touch the @src->lru field while in the
|
|
* migrate_page() function. It may write to @dst->lru.
|
|
*
|
|
* @putback_page:
|
|
* If migration fails on the isolated page, the VM informs the driver
|
|
* that the page is no longer a candidate for migration by calling
|
|
* this function. The driver should put the isolated page back into
|
|
* its own data structure.
|
|
*/
|
|
struct movable_operations {
|
|
bool (*isolate_page)(struct page *, isolate_mode_t);
|
|
int (*migrate_page)(struct page *dst, struct page *src,
|
|
enum migrate_mode);
|
|
void (*putback_page)(struct page *);
|
|
};
|
|
|
|
/* Defined in mm/debug.c: */
|
|
extern const char *migrate_reason_names[MR_TYPES];
|
|
|
|
#ifdef CONFIG_MIGRATION
|
|
|
|
void putback_movable_pages(struct list_head *l);
|
|
int migrate_folio(struct address_space *mapping, struct folio *dst,
|
|
struct folio *src, enum migrate_mode mode);
|
|
int migrate_pages(struct list_head *l, new_folio_t new, free_folio_t free,
|
|
unsigned long private, enum migrate_mode mode, int reason,
|
|
unsigned int *ret_succeeded);
|
|
struct folio *alloc_migration_target(struct folio *src, unsigned long private);
|
|
bool isolate_movable_ops_page(struct page *page, isolate_mode_t mode);
|
|
bool isolate_folio_to_list(struct folio *folio, struct list_head *list);
|
|
|
|
int migrate_huge_page_move_mapping(struct address_space *mapping,
|
|
struct folio *dst, struct folio *src);
|
|
void migration_entry_wait_on_locked(swp_entry_t entry, spinlock_t *ptl)
|
|
__releases(ptl);
|
|
void folio_migrate_flags(struct folio *newfolio, struct folio *folio);
|
|
int folio_migrate_mapping(struct address_space *mapping,
|
|
struct folio *newfolio, struct folio *folio, int extra_count);
|
|
int set_movable_ops(const struct movable_operations *ops, enum pagetype type);
|
|
|
|
#else
|
|
|
|
static inline void putback_movable_pages(struct list_head *l) {}
|
|
static inline int migrate_pages(struct list_head *l, new_folio_t new,
|
|
free_folio_t free, unsigned long private,
|
|
enum migrate_mode mode, int reason, unsigned int *ret_succeeded)
|
|
{ return -ENOSYS; }
|
|
static inline struct folio *alloc_migration_target(struct folio *src,
|
|
unsigned long private)
|
|
{ return NULL; }
|
|
static inline bool isolate_movable_ops_page(struct page *page, isolate_mode_t mode)
|
|
{ return false; }
|
|
static inline bool isolate_folio_to_list(struct folio *folio, struct list_head *list)
|
|
{ return false; }
|
|
|
|
static inline int migrate_huge_page_move_mapping(struct address_space *mapping,
|
|
struct folio *dst, struct folio *src)
|
|
{
|
|
return -ENOSYS;
|
|
}
|
|
static inline int set_movable_ops(const struct movable_operations *ops, enum pagetype type)
|
|
{
|
|
return -ENOSYS;
|
|
}
|
|
|
|
#endif /* CONFIG_MIGRATION */
|
|
|
|
#ifdef CONFIG_NUMA_BALANCING
|
|
int migrate_misplaced_folio_prepare(struct folio *folio,
|
|
struct vm_area_struct *vma, int node);
|
|
int migrate_misplaced_folio(struct folio *folio, int node);
|
|
#else
|
|
static inline int migrate_misplaced_folio_prepare(struct folio *folio,
|
|
struct vm_area_struct *vma, int node)
|
|
{
|
|
return -EAGAIN; /* can't migrate now */
|
|
}
|
|
static inline int migrate_misplaced_folio(struct folio *folio, int node)
|
|
{
|
|
return -EAGAIN; /* can't migrate now */
|
|
}
|
|
#endif /* CONFIG_NUMA_BALANCING */
|
|
|
|
#ifdef CONFIG_MIGRATION
|
|
|
|
/*
|
|
* Watch out for PAE architecture, which has an unsigned long, and might not
|
|
* have enough bits to store all physical address and flags. So far we have
|
|
* enough room for all our flags.
|
|
*/
|
|
#define MIGRATE_PFN_VALID (1UL << 0)
|
|
#define MIGRATE_PFN_MIGRATE (1UL << 1)
|
|
#define MIGRATE_PFN_WRITE (1UL << 3)
|
|
#define MIGRATE_PFN_SHIFT 6
|
|
|
|
static inline struct page *migrate_pfn_to_page(unsigned long mpfn)
|
|
{
|
|
if (!(mpfn & MIGRATE_PFN_VALID))
|
|
return NULL;
|
|
return pfn_to_page(mpfn >> MIGRATE_PFN_SHIFT);
|
|
}
|
|
|
|
static inline unsigned long migrate_pfn(unsigned long pfn)
|
|
{
|
|
return (pfn << MIGRATE_PFN_SHIFT) | MIGRATE_PFN_VALID;
|
|
}
|
|
|
|
enum migrate_vma_direction {
|
|
MIGRATE_VMA_SELECT_SYSTEM = 1 << 0,
|
|
MIGRATE_VMA_SELECT_DEVICE_PRIVATE = 1 << 1,
|
|
MIGRATE_VMA_SELECT_DEVICE_COHERENT = 1 << 2,
|
|
};
|
|
|
|
struct migrate_vma {
|
|
struct vm_area_struct *vma;
|
|
/*
|
|
* Both src and dst array must be big enough for
|
|
* (end - start) >> PAGE_SHIFT entries.
|
|
*
|
|
* The src array must not be modified by the caller after
|
|
* migrate_vma_setup(), and must not change the dst array after
|
|
* migrate_vma_pages() returns.
|
|
*/
|
|
unsigned long *dst;
|
|
unsigned long *src;
|
|
unsigned long cpages;
|
|
unsigned long npages;
|
|
unsigned long start;
|
|
unsigned long end;
|
|
|
|
/*
|
|
* Set to the owner value also stored in page_pgmap(page)->owner
|
|
* for migrating out of device private memory. The flags also need to
|
|
* be set to MIGRATE_VMA_SELECT_DEVICE_PRIVATE.
|
|
* The caller should always set this field when using mmu notifier
|
|
* callbacks to avoid device MMU invalidations for device private
|
|
* pages that are not being migrated.
|
|
*/
|
|
void *pgmap_owner;
|
|
unsigned long flags;
|
|
|
|
/*
|
|
* Set to vmf->page if this is being called to migrate a page as part of
|
|
* a migrate_to_ram() callback.
|
|
*/
|
|
struct page *fault_page;
|
|
};
|
|
|
|
int migrate_vma_setup(struct migrate_vma *args);
|
|
void migrate_vma_pages(struct migrate_vma *migrate);
|
|
void migrate_vma_finalize(struct migrate_vma *migrate);
|
|
int migrate_device_range(unsigned long *src_pfns, unsigned long start,
|
|
unsigned long npages);
|
|
int migrate_device_pfns(unsigned long *src_pfns, unsigned long npages);
|
|
void migrate_device_pages(unsigned long *src_pfns, unsigned long *dst_pfns,
|
|
unsigned long npages);
|
|
void migrate_device_finalize(unsigned long *src_pfns,
|
|
unsigned long *dst_pfns, unsigned long npages);
|
|
|
|
#endif /* CONFIG_MIGRATION */
|
|
|
|
#endif /* _LINUX_MIGRATE_H */
|