Eric Biggers 4dffc9bbff crypto: scatterwalk - Fix memcpy_sglist() to always succeed ...

The original implementation of memcpy_sglist() was broken because it
didn't handle scatterlists that describe exactly the same memory, which
is a case that many callers rely on.  The current implementation is
broken too because it calls the skcipher_walk functions which can fail.
It ignores any errors from those functions.

Fix it by replacing it with a new implementation written from scratch.
It always succeeds.  It's also a bit faster, since it avoids the
overhead of skcipher_walk.  skcipher_walk includes a lot of
functionality (such as alignmask handling) that's irrelevant here.

Reported-by: Colin Ian King <coking@nvidia.com>
Closes: https://lore.kernel.org/r/20251114122620.111623-1-coking@nvidia.com
Fixes: 131bdceca1f0 ("crypto: scatterwalk - Add memcpy_sglist")
Fixes: 0f8d42bf128d ("crypto: scatterwalk - Move skcipher walk and use it for memcpy_sglist")
Cc: stable@vger.kernel.org
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

2025-11-22 10:04:50 +08:00

..

asymmetric_keys

crypto: asymmetric_keys - fix uninitialized pointers with free attribute

2025-11-22 10:04:50 +08:00

async_tx

lib/raid6: replace custom zero page with ZERO_PAGE

2025-07-09 22:57:54 -07:00

krb5

crypto: krb5 - Fix memory leak in krb5_test_one_prf()

2025-07-18 20:52:00 +10:00

842.c

crypto: comp - Use same definition of context alloc and free ops

2025-09-20 20:21:03 +08:00

acompress.c

crypto: api - Rename CRYPTO_ALG_REQ_CHAIN to CRYPTO_ALG_REQ_VIRT

2025-05-05 18:20:45 +08:00

adiantum.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

aead.c

crypto: aead - Add support for on-stack AEAD req allocation

2025-10-31 17:43:56 +08:00

aegis128-core.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

aegis128-neon-inner.c

…

aegis128-neon.c

…

aegis-neon.h

…

aegis.h

…

aes_generic.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

aes_ti.c

…

af_alg.c

crypto: af_alg - zero initialize memory allocated via sock_kmalloc

2025-10-17 16:03:57 +08:00

ahash.c

crypto: remove nth_page() usage within SG entry

2025-09-21 14:22:09 -07:00

akcipher.c

crypto: api - Add support for duplicating algorithms before registration

2025-04-16 15:36:24 +08:00

algapi.c

crypto: algapi - Add driver template support to crypto_inst_setname

2025-05-19 13:48:20 +08:00

algboss.c

crypto: testmgr - replace CRYPTO_MANAGER_DISABLE_TESTS with CRYPTO_SELFTESTS

2025-05-12 13:33:14 +08:00

algif_aead.c

crypto: algif_aead - use memcpy_sglist() instead of null skcipher

2025-05-12 13:32:53 +08:00

algif_hash.c

crypto: af_alg - zero initialize memory allocated via sock_kmalloc

2025-10-17 16:03:57 +08:00

algif_rng.c

crypto: af_alg - zero initialize memory allocated via sock_kmalloc

2025-10-17 16:03:57 +08:00

algif_skcipher.c

…

anubis.c

crypto: anubis - simplify return statement in anubis_mod_init

2025-09-20 20:21:04 +08:00

api.c

crypto: api - Redo lookup on EEXIST

2025-05-23 19:25:47 +08:00

arc4.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

aria_generic.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

authenc.c

crypto: authenc - Correctly pass EINPROGRESS back up to the caller

2025-10-17 16:03:58 +08:00

authencesn.c

crypto: authenc - use memcpy_sglist() instead of null skcipher

2025-05-12 13:32:53 +08:00

blake2b_generic.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

blowfish_common.c

…

blowfish_generic.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

bpf_crypto_skcipher.c

crypto: bpf - Add MODULE_DESCRIPTION for skcipher

2025-03-02 15:19:43 +08:00

camellia_generic.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

cast5_generic.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

cast6_generic.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

cast_common.c

…

cbc.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

ccm.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

chacha20poly1305.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

chacha.c

crypto: chacha - register only "-lib" drivers

2025-08-29 09:50:19 -07:00

cipher.c

module: Convert symbol namespace to string literal

2024-12-02 11:34:44 -08:00

cmac.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

compress.h

crypto: acomp - Move stream management into scomp layer

2025-03-15 16:21:22 +08:00

crc32.c

crypto/crc32[c]: register only "-lib" drivers

2025-06-30 09:31:56 -07:00

crc32c.c

crypto/crc32[c]: register only "-lib" drivers

2025-06-30 09:31:56 -07:00

cryptd.c

crypto: cryptd - WQ_PERCPU added to alloc_workqueue users

2025-09-13 12:11:06 +08:00

crypto_engine.c

crypto: engine - remove {prepare,unprepare}_crypt_hardware callbacks

2025-07-18 20:52:00 +10:00

crypto_null.c

crypto: null - use memcpy_sglist()

2025-05-12 13:32:53 +08:00

crypto_user.c

crypto: remove obsolete 'comp' compression API

2025-03-21 17:39:06 +08:00

ctr.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

cts.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

deflate.c

crypto: deflate - Use struct_size to improve deflate_alloc_stream

2025-11-06 14:31:08 +08:00

des_generic.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

df_sp80090a.c

crypto: drbg - make drbg_{ctr_bcc,kcapi_sym}() return *void*

2025-10-17 16:10:27 +08:00

dh_helper.c

…

dh.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

drbg.c

crypto: drbg - Replace AES cipher calls with library calls

2025-10-17 16:03:57 +08:00

ecb.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

ecc_curve_defs.h

…

ecc.c

crypto: ecdsa - Harden against integer overflows in DIV_ROUND_UP()

2025-02-09 18:08:12 +08:00

ecdh_helper.c

…

ecdh.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

ecdsa-p1363.c

crypto: ecdsa - Fix NIST P521 key size reported by KEYCTL_PKEY_QUERY

2025-04-16 15:16:21 +08:00

ecdsa-x962.c

crypto: ecdsa - Fix NIST P521 key size reported by KEYCTL_PKEY_QUERY

2025-04-16 15:16:21 +08:00

ecdsa.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

ecdsasignature.asn1

…

echainiv.c

crypto: geniv - use memcpy_sglist() instead of null skcipher

2025-05-12 13:32:53 +08:00

ecrdsa_defs.h

…

ecrdsa_params.asn1

…

ecrdsa_pub_key.asn1

…

ecrdsa.c

crypto: ecdsa - Fix NIST P521 key size reported by KEYCTL_PKEY_QUERY

2025-04-16 15:16:21 +08:00

essiv.c

crypto: essiv - Check ssize for decryption and in-place encryption

2025-10-09 15:02:35 +08:00

fcrypt.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

fips.c

crypto: fips - replace simple_strtol with kstrtoint to improve fips_enable

2025-10-17 16:03:57 +08:00

gcm.c

crypto: gcm - use memcpy_sglist() instead of null skcipher

2025-05-12 13:32:53 +08:00

geniv.c

crypto: geniv - use memcpy_sglist() instead of null skcipher

2025-05-12 13:32:53 +08:00

ghash-generic.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

hash.h

…

hctr2.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

hkdf.c

crypto: hkdf - move to late_initcall

2025-06-11 10:59:45 +08:00

hmac.c

crypto: hmac - Add ahash support

2025-05-19 13:48:20 +08:00

internal.h

crypto: testmgr - replace CRYPTO_MANAGER_DISABLE_TESTS with CRYPTO_SELFTESTS

2025-05-12 13:33:14 +08:00

jitterentropy-kcapi.c

crypto: jitter - Mark intermediary memory as clean

2025-08-30 15:43:25 +08:00

jitterentropy-testing.c

…

jitterentropy.c

crypto: jitter - replace ARRAY_SIZE definition with header include

2025-07-18 20:52:01 +10:00

jitterentropy.h

…

Kconfig

crypto: ansi_cprng - Remove unused ansi_cprng algorithm

2025-11-22 10:04:50 +08:00

kdf_sp800108.c

crypto: testmgr - replace CRYPTO_MANAGER_DISABLE_TESTS with CRYPTO_SELFTESTS

2025-05-12 13:33:14 +08:00

khazad.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

kpp.c

crypto: api - Add support for duplicating algorithms before registration

2025-04-16 15:36:24 +08:00

krb5enc.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

lrw.c

crypto: lrw - Only add ecb if it is not already there

2025-05-19 13:48:20 +08:00

lskcipher.c

crypto: api - Add support for duplicating algorithms before registration

2025-04-16 15:36:24 +08:00

lz4.c

crypto: comp - Use same definition of context alloc and free ops

2025-09-20 20:21:03 +08:00

lz4hc.c

crypto: comp - Use same definition of context alloc and free ops

2025-09-20 20:21:03 +08:00

lzo-rle.c

crypto: comp - Use same definition of context alloc and free ops

2025-09-20 20:21:03 +08:00

lzo.c

crypto: comp - Use same definition of context alloc and free ops

2025-09-20 20:21:03 +08:00

Makefile

crypto: ansi_cprng - Remove unused ansi_cprng algorithm

2025-11-22 10:04:50 +08:00

md4.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

md5.c

crypto: md5 - Implement export_core() and import_core()

2025-09-08 09:47:38 -07:00

michael_mic.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

nhpoly1305.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

pcbc.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

pcrypt.c

crypto: pcrypt - Optimize pcrypt_aead_init_tfm()

2025-06-13 17:26:17 +08:00

polyval-generic.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

proc.c

crypto: remove obsolete 'comp' compression API

2025-03-21 17:39:06 +08:00

ripemd.h

…

rmd160.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

rng.c

crypto: rng - Ensure set_ent is always present

2025-10-06 10:17:07 +08:00

rsa_helper.c

…

rsa-pkcs1pad.c

…

rsa.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

rsaprivkey.asn1

…

rsapubkey.asn1

…

rsassa-pkcs1.c

crypto: ecdsa - Fix NIST P521 key size reported by KEYCTL_PKEY_QUERY

2025-04-16 15:16:21 +08:00

scatterwalk.c

crypto: scatterwalk - Fix memcpy_sglist() to always succeed

2025-11-22 10:04:50 +08:00

scompress.c

crypto: remove nth_page() usage within SG entry

2025-09-21 14:22:09 -07:00

seed.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

seqiv.c

crypto: geniv - use memcpy_sglist() instead of null skcipher

2025-05-12 13:32:53 +08:00

serpent_generic.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

sha1.c

crypto: sha1 - Implement export_core() and import_core()

2025-09-02 19:02:35 -07:00

sha3_generic.c

crypto: sha3-generic - Use API partial block handling

2025-04-23 15:52:46 +08:00

sha256.c

crypto: sha256 - Implement export_core() and import_core()

2025-09-02 19:02:37 -07:00

sha512.c

crypto: sha512 - Implement export_core() and import_core()

2025-09-02 19:02:39 -07:00

shash.c

crypto: shash - Fix buffer overrun in import function

2025-05-27 13:43:32 +08:00

sig.c

crypto: api - Add support for duplicating algorithms before registration

2025-04-16 15:36:24 +08:00

simd.c

…

skcipher.c

crypto: skcipher - Fix reqsize handling

2025-10-08 16:13:07 +08:00

skcipher.h

…

sm3_generic.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

sm4_generic.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

sm4.c

…

streebog_generic.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

tcrypt.c

crypto: tcrypt - Remove unused poly1305 support

2025-11-22 10:04:50 +08:00

tcrypt.h

crypto: tcrypt - Remove unused poly1305 support

2025-11-22 10:04:50 +08:00

tea.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

testmgr.c

crypto: ansi_cprng - Remove unused ansi_cprng algorithm

2025-11-22 10:04:50 +08:00

testmgr.h

crypto: ansi_cprng - Remove unused ansi_cprng algorithm

2025-11-22 10:04:50 +08:00

twofish_common.c

…

twofish_generic.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

wp512.c

crypto: wp512 - Use API partial block handling

2025-06-23 16:56:56 +08:00

xcbc.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

xctr.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

xor.c

…

xts.c

crypto: xts - Only add ecb if it is not already there

2025-05-19 13:48:20 +08:00

xxhash_generic.c

Revert "crypto: run initcalls for generic implementations earlier"

2025-05-05 18:20:44 +08:00

zstd.c

crypto: zstd - Remove unnecessary size_t cast

2025-11-14 18:15:49 +08:00