1
0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-01-20 21:34:54 +00:00
Simon Horman 1224b218a4 pldmfw: Select CRC32 when PLDMFW is selected
pldmfw calls crc32 code and depends on it being enabled, else
there is a link error as follows. So PLDMFW should select CRC32.

  lib/pldmfw/pldmfw.o: In function `pldmfw_flash_image':
  pldmfw.c:(.text+0x70f): undefined reference to `crc32_le_base'

This problem was introduced by commit b8265621f488 ("Add pldmfw library
for PLDM firmware update").

It manifests as of commit d69ea414c9b4 ("ice: implement device flash
update via devlink").

And is more likely to occur as of commit 9ad19171b6d6 ("lib/crc: remove
unnecessary prompt for CONFIG_CRC32 and drop 'default y'").

Found by chance while exercising builds based on tinyconfig.

Fixes: b8265621f488 ("Add pldmfw library for PLDM firmware update")
Signed-off-by: Simon Horman <horms@kernel.org>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20250613-pldmfw-crc32-v1-1-f3fad109eee6@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2025-06-16 14:12:08 -07:00
..
2024-12-12 18:26:32 +01:00
2025-06-03 07:39:23 -07:00
2025-03-16 22:30:49 -07:00
2025-04-11 17:32:38 -07:00
2025-04-11 17:32:37 -07:00
2025-05-28 15:24:36 -07:00
2025-05-15 20:24:40 +02:00
2025-03-25 10:18:31 -03:00
2025-01-12 20:21:15 -08:00
2025-01-14 19:45:35 +01:00
2024-10-14 16:33:24 -05:00
2025-03-17 12:17:00 -07:00
2025-05-11 17:54:04 -07:00
2025-05-11 17:54:08 -07:00
2025-03-25 10:18:31 -03:00
2025-05-28 09:46:39 -07:00
2024-12-09 13:48:29 -08:00