Matthew Wilcox (Oracle)
7e934cf5ac
xarray: Fix early termination of xas_for_each_marked ...
xas_for_each_marked() is using entry == NULL as a termination condition
of the iteration. When xas_for_each_marked() is used protected only by
RCU, this can however race with xas_store(xas, NULL) in the following
way:
TASK1 TASK2
page_cache_delete() find_get_pages_range_tag()
xas_for_each_marked()
xas_find_marked()
off = xas_find_chunk()
xas_store(&xas, NULL)
xas_init_marks(&xas);
...
rcu_assign_pointer(*slot, NULL);
entry = xa_entry(off);
And thus xas_for_each_marked() terminates prematurely possibly leading
to missed entries in the iteration (translating to missing writeback of
some pages or a similar problem).
If we find a NULL entry that has been marked, skip it (unless we're trying
to allocate an entry).
Reported-by: Jan Kara <jack@suse.cz>
CC: stable@vger.kernel.org
Fixes: ef8e5717db01 ("page cache: Convert delete_batch to XArray")
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
2020-03-12 17:42:08 -04:00
2020-01-02 15:34:27 +01:00
2019-11-27 22:28:37 +01:00
2019-11-27 08:15:00 -08:00
2019-12-05 11:43:31 -08:00
2019-12-03 09:29:50 -08:00
2019-12-11 13:22:54 +01:00
2019-11-27 10:17:28 -08:00
2020-01-09 20:08:15 +01:00
2020-01-24 20:54:29 +01:00
2019-12-10 07:18:21 -08:00
2019-12-12 17:59:43 +01:00
2019-12-05 11:43:31 -08:00
2019-12-27 23:03:43 +00:00
2019-12-07 16:56:00 -08:00
2019-12-04 13:32:45 +10:00
2019-12-25 20:47:19 -07:00
2019-12-28 09:44:56 -07:00
2019-12-04 19:44:14 -08:00
2019-12-04 19:44:12 -08:00
2019-12-12 09:26:55 -07:00
2020-01-15 21:43:09 -07:00
2019-12-17 08:58:02 -08:00
2019-12-16 10:59:29 -08:00
2019-12-04 19:44:12 -08:00
2020-01-04 20:23:39 -07:00
2019-12-01 14:00:59 -08:00
2019-11-26 10:26:26 +01:00
2019-12-12 17:59:43 +01:00
2019-11-26 09:43:34 -08:00
2019-11-29 11:48:39 +01:00
2019-12-09 12:19:16 +09:00
2019-12-12 14:49:57 +01:00
2019-11-28 11:16:43 -08:00
2019-12-11 16:03:20 +05:30
2019-12-03 11:20:37 +01:00
2019-12-08 12:42:19 +01:00
2019-12-05 12:27:16 -08:00
2019-12-02 14:46:22 -08:00
2019-12-09 10:36:44 -08:00
2019-12-02 14:46:22 -08:00
2019-12-11 12:22:38 -08:00
2019-11-27 11:06:20 -08:00
2019-12-04 19:44:13 -08:00
2020-01-26 09:59:08 -07:00
2019-12-01 12:59:06 -08:00
2019-12-01 12:59:08 -08:00
2019-12-11 08:39:07 +01:00
2020-01-08 12:52:33 -08:00
2019-12-12 18:58:24 +01:00
2019-12-03 12:20:25 -08:00
2019-12-22 10:41:48 -08:00
2019-12-17 20:59:59 -08:00
2019-12-04 19:44:14 -08:00
2019-12-30 12:01:56 -08:00
2019-12-09 10:36:44 -08:00
2019-12-25 17:08:33 -07:00
2019-11-26 13:35:25 -07:00
2019-12-01 12:59:08 -08:00
2019-12-01 12:59:07 -08:00
2020-01-04 13:55:08 -08:00
2019-12-06 10:28:09 -08:00
2020-01-13 18:19:02 -08:00
2020-01-13 18:19:02 -08:00
2019-12-20 21:47:04 -08:00
2019-12-01 12:59:05 -08:00
2020-01-15 01:36:06 -05:00
2020-01-23 11:14:21 +01:00
2019-12-04 19:44:12 -08:00
2019-11-27 02:48:27 +09:00
2019-11-27 10:53:50 -08:00
2019-12-26 15:17:26 -08:00
2019-12-01 12:59:04 -08:00
2019-12-03 13:58:22 -08:00
2019-11-25 14:28:04 -08:00
2019-11-26 15:04:47 -08:00
2019-12-09 10:36:44 -08:00
2019-12-20 21:48:06 -08:00
2019-12-07 13:21:01 -08:00
2019-11-29 12:04:50 +01:00
2019-12-30 20:19:27 -08:00
2019-12-06 10:47:28 +01:00
2019-12-04 19:44:11 -08:00
2019-12-06 10:28:09 -08:00
2019-12-04 19:44:13 -08:00
2019-12-13 21:40:49 -08:00
2019-11-26 16:02:40 -08:00
2019-12-05 11:43:31 -08:00
2019-12-05 11:43:31 -08:00
2019-12-25 10:41:20 +01:00
2019-11-30 14:35:43 -08:00
2019-12-04 17:11:25 -08:00
2020-01-15 23:26:13 +01:00
2019-12-01 06:29:17 -08:00
2019-12-03 07:04:30 -07:00
2019-12-01 06:29:18 -08:00
2019-12-01 12:59:07 -08:00
2020-01-06 13:33:14 -08:00
2020-01-02 16:15:33 -08:00
2019-12-04 19:44:11 -08:00
2019-12-04 19:44:14 -08:00
2019-11-26 15:42:43 -08:00
2019-12-06 21:05:14 -08:00
2020-01-15 13:39:59 -08:00
2019-12-17 11:46:43 +02:00
2019-12-01 14:00:59 -08:00
2019-12-01 12:59:05 -08:00
2019-12-04 19:44:11 -08:00
2020-03-12 17:42:08 -04:00
7e934cf5ac