Gustavo A. R. Silva
e7bb7ecefa
IB/mlx4: Replace zero-length array with flexible-array ...
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by
this change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
sizeof(flexible-array-member) triggers a warning because flexible array
members have incomplete type[1]. There are some instances of code in
which the sizeof operator is being incorrectly/erroneously applied to
zero-length arrays and the result is zero. Such instances may be hiding
some bugs. So, this work (flexible-array member conversions) will also
help to get completely rid of those sorts of issues.
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2020-05-09 20:49:13 -07:00
2020-04-01 08:03:28 +02:00
2020-04-18 15:44:54 -05:00
2020-03-30 12:42:42 +02:00
2020-02-18 21:47:54 +01:00
2020-03-04 18:11:44 +01:00
2020-03-24 16:19:01 -07:00
2020-04-03 15:05:35 -07:00
2020-04-30 20:25:37 -07:00
2020-03-31 21:29:04 +02:00
2020-04-20 14:07:00 +02:00
2020-04-16 10:28:12 +01:00
2020-04-08 21:29:10 -07:00
2020-05-09 20:49:13 -07:00
2020-05-09 01:05:30 -07:00
2020-03-26 14:45:31 +01:00
2020-03-30 10:14:19 +02:00
2020-03-15 15:20:16 +01:00
2020-03-15 15:20:16 +01:00
2020-03-15 15:20:16 +01:00
2020-03-15 15:20:16 +01:00
2020-03-15 15:20:16 +01:00
2020-03-17 22:50:30 +00:00
2020-03-19 13:59:46 +01:00
2020-03-31 22:08:54 +02:00
2020-05-06 16:40:14 -07:00
2020-04-10 15:36:22 -07:00
2020-03-30 11:45:18 -07:00
2020-03-24 07:57:08 -06:00
2020-03-18 21:57:20 +00:00
2020-03-08 22:07:09 -07:00
2020-04-28 21:23:38 +02:00
2020-04-03 15:05:35 -07:00
2020-03-20 19:25:14 +05:30
2020-04-07 19:44:52 -07:00
2020-05-02 11:24:01 -07:00
2020-03-16 22:08:34 -04:00
2020-04-02 15:50:04 -07:00
2020-04-08 21:03:40 -07:00
2020-03-28 13:19:05 -05:00
2020-03-31 10:05:01 -07:00
2020-02-24 16:12:28 +01:00
2020-04-17 21:38:11 -06:00
2020-03-25 10:03:36 -05:00
2020-04-18 15:44:54 -05:00
2020-03-12 15:48:37 -07:00
2020-03-05 13:23:25 -08:00
2020-04-07 10:43:42 -07:00
2020-04-07 10:43:43 -07:00
2020-04-18 15:44:54 -05:00
2020-04-01 14:56:44 -06:00
2020-04-18 15:44:54 -05:00
2020-03-30 11:43:51 -07:00
2020-02-25 08:40:07 -07:00
2020-03-03 17:38:42 -05:00
2020-03-30 01:34:00 +02:00
2020-04-28 17:27:08 -07:00
2020-03-30 14:59:53 -07:00
2020-04-28 17:27:08 -07:00
2020-05-01 10:36:32 -07:00
2020-04-30 20:55:49 -07:00
2020-04-15 23:58:48 -04:00
2020-04-03 11:30:20 -07:00
2020-02-12 17:57:51 -05:00
2020-03-25 17:38:23 -07:00
2020-03-21 15:23:56 +01:00
2020-04-10 15:36:21 -07:00
2020-04-27 02:07:40 -04:00
2020-03-31 11:04:05 -07:00
2020-04-07 10:43:42 -07:00
2020-04-07 10:43:42 -07:00
2020-03-21 16:00:24 +01:00
2020-03-17 15:26:43 +01:00
2020-03-21 15:23:53 +01:00
2020-04-27 02:06:53 -04:00
2020-03-21 11:32:20 +01:00
2020-04-18 15:44:55 -05:00
2020-03-28 11:42:55 +01:00
2020-03-06 16:02:50 +00:00
2020-03-16 15:48:54 +00:00
2020-03-20 13:06:18 +01:00
2020-04-03 11:32:13 -04:00
2020-04-02 19:15:03 -07:00
2020-02-28 12:08:37 -08:00
2020-04-17 17:08:50 +02:00
2020-05-06 17:03:34 -07:00
2020-04-07 10:45:15 +02:00
2020-03-25 08:35:03 +09:00
2020-04-02 19:15:03 -07:00
2020-04-08 11:00:00 -07:00
2020-04-18 15:44:54 -05:00
2020-03-09 11:12:19 +01:00
2020-04-18 15:44:54 -05:00
2020-04-30 19:47:39 +05:30
2020-03-16 10:48:12 +01:00
2020-04-27 21:26:23 +05:30
2020-03-10 10:30:52 +01:00
2020-02-27 12:15:24 +01:00
2020-02-17 13:37:00 +01:00
2020-03-20 14:57:54 +01:00
2020-03-31 11:04:05 -07:00
2020-03-21 15:24:00 +01:00
2020-04-18 15:44:54 -05:00
2020-04-18 15:44:54 -05:00
2020-03-22 23:06:34 +01:00
2020-05-04 11:19:58 -07:00
2020-04-18 15:44:54 -05:00
2020-03-19 07:41:01 +01:00
2020-03-25 08:16:13 +09:00
2020-03-22 21:16:28 -07:00
2020-03-25 23:17:16 +01:00
2020-04-27 02:06:53 -04:00
2020-04-26 08:53:13 -07:00
2020-03-20 14:54:04 +01:00
2020-02-07 14:48:39 -05:00
2020-02-07 14:48:38 -05:00
2020-05-06 22:10:13 -07:00
2020-03-19 21:56:54 -07:00
2020-03-25 10:27:16 +01:00
2020-03-25 10:27:16 +01:00
2020-04-27 02:07:40 -04:00
2020-03-06 11:06:15 +01:00
2020-03-04 17:58:48 +01:00
2020-04-18 15:44:54 -05:00
2020-03-30 11:20:13 -07:00
2020-04-07 10:43:38 -07:00
2020-02-10 12:58:36 +01:00
2020-03-21 16:03:53 +01:00
2020-03-17 17:25:06 +01:00
2020-02-26 13:31:18 +02:00
2020-02-12 14:18:33 +01:00
2020-03-27 20:19:24 -03:00
2020-04-07 10:43:39 -07:00
2020-04-02 09:35:32 -07:00
2020-04-27 02:07:40 -04:00
2020-03-10 12:20:04 +01:00
2020-04-15 11:48:21 +02:00
2020-02-25 11:01:39 -08:00
2020-03-29 21:25:29 -07:00
2020-04-27 11:40:25 -07:00
2020-05-07 18:11:07 -07:00
2020-04-18 15:44:55 -05:00
2020-04-18 15:44:55 -05:00
2020-03-12 07:43:57 -04:00
2020-04-30 12:54:01 -07:00
2020-03-13 14:25:46 +01:00
2020-02-10 10:41:20 +01:00
2020-03-08 11:06:42 +01:00
2020-03-11 14:15:20 -06:00
2020-02-19 11:21:41 -08:00
2020-03-12 07:07:38 -06:00
2020-03-27 11:14:52 +01:00
2020-05-06 11:29:25 +03:00
2020-03-29 22:30:57 -07:00
2020-03-21 16:00:24 +01:00
2020-04-19 11:23:33 -07:00
2020-03-17 19:13:32 +01:00
2020-02-21 11:29:15 +01:00
2020-04-01 13:20:14 +02:00
2020-03-21 15:23:58 +01:00
2020-04-02 09:35:30 -07:00
2020-02-20 21:17:24 +01:00
2020-03-16 15:53:47 -04:00
2020-03-29 12:40:41 +01:00
2020-02-12 12:05:46 +01:00
2020-04-27 02:07:40 -04:00
2020-04-02 09:35:25 -07:00
2020-03-30 18:51:47 -07:00
2020-04-14 10:39:56 -04:00
2020-04-27 02:07:40 -04:00
2020-04-06 22:55:27 +02:00
2020-03-26 10:28:20 -06:00
2020-03-17 12:23:21 -07:00
2020-03-31 17:29:33 -07:00
2020-02-16 19:39:44 -08:00
2020-04-18 15:44:55 -05:00
2020-03-17 17:25:06 +01:00
2020-03-23 18:40:25 +01:00
2020-03-30 01:34:00 +02:00
2020-03-31 17:29:33 -07:00
2020-03-21 15:23:56 +01:00
2020-03-09 20:13:16 -07:00
2020-03-17 22:51:16 -07:00
2020-04-10 15:36:21 -07:00
2020-04-18 15:44:55 -05:00
2020-04-10 15:36:21 -07:00
2020-04-07 10:43:40 -07:00
2020-04-02 09:35:31 -07:00
2020-04-08 21:03:40 -07:00
2020-03-26 15:51:07 +01:00
2020-03-26 14:33:38 -03:00
2020-03-15 17:10:14 -07:00
2020-03-06 11:56:59 +01:00
2020-03-19 07:41:02 +01:00
2020-04-07 10:43:38 -07:00
2020-04-07 10:43:41 -07:00
2020-04-27 02:07:40 -04:00
2020-04-27 02:07:40 -04:00
2020-04-03 13:22:40 -07:00
2020-03-24 13:42:44 +01:00
2020-03-24 07:57:08 -06:00
2020-03-21 16:00:24 +01:00
2020-03-13 21:08:19 -04:00
2020-04-30 12:56:36 -07:00
2020-05-09 01:05:30 -07:00
2020-03-18 16:35:48 -07:00
2020-03-25 18:58:11 -07:00
2020-05-07 18:11:07 -07:00
2020-04-06 13:56:33 -04:00
2020-04-01 13:37:57 -04:00
2020-04-28 15:58:38 -04:00
2020-04-27 02:07:40 -04:00
2020-02-18 10:28:05 -08:00
2020-04-04 09:09:39 +02:00
2020-03-19 07:41:02 +01:00
2020-02-14 14:25:26 -06:00
2020-02-12 12:57:59 -08:00
2020-02-10 12:58:36 +01:00
2020-04-22 19:41:26 -07:00
2020-04-02 09:35:27 -07:00
2020-04-07 10:43:39 -07:00
2020-04-07 10:43:38 -07:00
2020-04-07 10:43:38 -07:00
2020-03-25 09:50:09 -06:00
2020-04-03 14:25:02 -07:00
2020-03-28 13:19:04 -05:00
2020-04-02 17:57:10 +01:00
2020-04-02 17:57:10 +01:00
2020-04-03 14:25:02 -07:00
2020-02-23 21:59:42 +01:00
2020-04-07 10:43:43 -07:00
2020-02-11 13:10:58 +01:00
2020-04-27 02:07:40 -04:00
2020-05-06 17:45:45 -07:00
2020-04-24 16:45:37 -07:00
2020-02-28 12:06:14 -06:00
2020-04-27 02:06:53 -04:00
2020-02-12 11:54:08 -08:00
2020-04-01 08:06:54 +02:00
2020-02-14 10:37:27 +01:00
2020-03-04 11:01:18 +01:00
2020-04-22 11:36:11 +02:00
2020-04-18 15:44:55 -05:00
2020-03-04 09:54:55 +01:00
2020-02-20 21:17:24 +01:00
2020-04-27 02:07:40 -04:00
2020-04-07 10:43:42 -07:00
2020-04-02 11:22:17 -07:00
2020-03-20 13:06:18 +01:00
2020-03-20 13:06:19 +01:00
2020-05-02 16:31:44 -07:00
2020-03-18 15:05:57 +00:00
2020-03-30 16:55:26 +02:00
2020-02-07 14:48:37 -05:00
2020-02-27 23:21:52 -05:00
2020-02-17 10:55:14 +01:00
2020-02-20 15:58:23 -08:00
2020-02-20 16:03:30 -08:00
2020-02-20 16:03:30 -08:00
2020-03-21 16:00:22 +01:00
2020-04-08 12:05:07 +02:00
2020-02-19 18:12:31 +00:00
2020-03-25 22:29:45 -07:00
2020-03-06 22:33:38 -08:00
2020-03-27 16:39:01 -04:00
2020-04-18 15:44:56 -05:00
2020-04-18 15:44:56 -05:00
2020-04-02 18:47:30 +02:00
2020-03-21 16:00:24 +01:00
2020-03-21 16:00:24 +01:00
2020-04-02 11:22:17 -07:00
2020-03-04 14:48:54 -08:00
2020-04-27 02:07:40 -04:00
2020-02-21 10:31:18 +01:00
2020-04-07 10:43:42 -07:00
2020-03-17 15:58:00 +01:00
2020-03-12 17:16:42 +01:00
2020-04-07 10:43:38 -07:00
2020-03-26 14:41:22 -04:00
2020-04-18 15:44:56 -05:00
2020-03-09 22:34:58 +01:00
2020-04-10 15:36:20 -07:00
2020-03-30 12:18:49 -07:00
2020-03-21 16:00:24 +01:00
2020-03-21 16:00:24 +01:00
2020-03-02 14:04:31 -07:00
2020-04-07 10:43:43 -07:00
2020-03-18 09:50:20 +00:00
2020-04-21 15:54:45 -07:00
2020-03-23 13:41:55 +01:00
2020-04-18 15:44:56 -05:00
2020-04-07 10:43:41 -07:00
2020-02-05 18:53:05 +01:00
2020-04-27 02:07:40 -04:00
2020-04-05 11:34:35 -07:00
2020-03-07 09:52:02 +01:00
2020-05-06 22:10:13 -07:00
2020-02-28 13:37:42 +01:00
2020-03-12 11:56:53 +01:00
2020-03-21 17:48:13 +01:00
2020-04-18 15:44:56 -05:00
2020-03-30 18:51:47 -07:00
2020-03-21 15:23:58 +01:00
2020-03-21 15:23:57 +01:00
2020-02-21 11:22:15 -08:00
2020-04-27 02:07:40 -04:00
2020-03-30 14:59:53 -07:00
2020-04-02 09:35:26 -07:00
2020-04-18 15:44:56 -05:00
2020-03-19 17:48:36 -04:00
2020-04-22 22:06:35 -04:00
2020-05-04 09:16:37 -07:00
2020-02-21 11:22:15 -08:00
2020-03-06 12:28:24 +11:00
2020-03-18 12:34:10 +01:00
2020-02-19 11:08:52 +01:00
2020-02-23 19:24:51 +01:00
2020-02-23 19:24:51 +01:00
2020-04-07 10:43:39 -07:00
2020-03-23 17:01:47 +01:00
2020-04-17 06:05:30 -04:00
2020-04-25 20:18:53 -07:00
2020-03-24 09:32:41 -06:00
2020-04-01 12:06:26 -04:00
2020-05-06 17:23:06 -07:00
2020-04-27 10:18:01 -07:00
2020-04-17 06:05:30 -04:00
2020-04-07 10:43:38 -07:00
2020-04-21 11:11:56 -07:00
2020-04-27 02:07:40 -04:00
2020-04-16 18:31:08 -04:00
2020-03-06 08:35:39 +01:00
2020-02-11 13:10:56 +01:00
2020-04-03 12:27:36 -07:00
2020-04-27 02:07:40 -04:00
2020-03-12 17:42:08 -04:00
2020-04-18 15:44:56 -05:00
2020-03-09 11:12:19 +01:00
e7bb7ecefa